Repository navigation
feat: via_image_from image_is_convolved + from_gaussian oversample kwarg - #359
Merged
Merged
Conversation
…le kwarg (#482 support) SimulatorImaging.via_image_from gains image_is_convolved (default False, behaviour unchanged): skip the internal PSF convolution when handed an already-convolved image, e.g. one convolved at the fine resolution by an oversampled Convolver. Convolver.from_gaussian passes through convolve_over_sample_size. Supports oversampled-PSF simulation (PyAutoLabs/PyAutoGalaxy#482). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for oversampled-PSF simulation (PyAutoLabs/PyAutoGalaxy#482):
SimulatorImaging.via_image_fromgainsimage_is_convolved: bool = Falseto skip internal convolution for images already convolved at the fine resolution;Convolver.from_gaussianpasses throughconvolve_over_sample_size. Simulate-and-fit consistency test ties the simulator path to the fit-side convolution exactly (chi²≈0). Suite: 863 passed. Merge first in the #482 chain.🤖 Generated with Claude Code